fix/feature: site/client maintenance mode now requires every agent to be in maintenance mode - #2526
Open
BuddiesD wants to merge 1 commit into
Open
fix/feature: site/client maintenance mode now requires every agent to be in maintenance mode#2526BuddiesD wants to merge 1 commit into
BuddiesD wants to merge 1 commit into
Conversation
…aintenance. Changed maintenance_mode annotation from Exists() to Case/When so that a site/client only shows as in maintenance when all agents are in maintenance mode.
Contributor
Author
BuddiesD
changed the title
|
+1, I'd love to see this merged. The current behavior of flagging a whole client/site as "in maintenance" when only one agent is in maintenance mode has been confusing for us too. This fix makes the indicator actually meaningful. Thanks for the work! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the maintenance mode indicator to only display when a client or site is indeed fully in maintenance mode.
Previously, the indicator was shown whenever any agent was in maintenance mode, which could be misleading. (it really bugs me, maybe its a feature request?)
Changes
maintenance_modeannotation fromExiststoCase/WhenNotes
Current (this PR):
I also experimented with a few alternative designs:
Only display the maintenance icon when all agents within a site/client are in maintenance mode:
Display a maintenance icon in the corner when one or more agents in a site/client are in maintenance mode:
please ignore the different sizes and styles caused by different browsers 😅
I'm not sure which approach is preferred. If desired, we could include multiple display options and make the behavior configurable through the settings.
a ❤️ for the TRMM Dev's