Skip to content

Remove the Community Applications template - #28

Merged
andrebrait merged 1 commit into
mainfrom
chore/drop-ca-template
Nov 9, 2026
Merged

andrebrait merged 1 commit into
mainfrom
chore/drop-ca-template

Conversation

@andrebrait

@andrebrait andrebrait commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

The CA feed now lists FanCtrl Plus 2 from andrebrait/unraid-templates (templates/fanctrlplus2.xml; repository entry https://github.com/andrebrait/unraid-templates), so this repository's copies of FanctrlPlus2.xml and ca_profile.xml are unused. Nothing else references them.

The plugin's pluginURL still points at plugin/fanctrlplus2.plg here, so installs and updates are unaffected.

Follows andrebrait/unraid-templates#2.

Summary by CodeRabbit

  • Chores
    • FanCtrl Plus 2’s plugin listing and maintainer profile information are no longer included.

The FanCtrl Plus 2 template and the CA maintainer profile now live in
andrebrait/unraid-templates, and the CA feed reads them from there. The
plugin still installs and updates from plugin/fanctrlplus2.plg in this
repository.
@andrebrait

Copy link
Copy Markdown
Owner Author

@codex review

@andrebrait

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T10:47:41.493685Z c3c6cd5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request deletes the FanctrlPlus2.xml plugin metadata and the ca_profile.xml maintainer profile.

Changes: Plugin Metadata Removal

Layer / File(s) Summary
Remove plugin metadata and maintainer profile
FanctrlPlus2.xml, ca_profile.xml
The plugin declaration and maintainer profile XML are deleted.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: ck9393

Merge Risk: Minimal · up to c3c6c

No actionable merge-blocking issue was found. The plugin installation and update paths remain unchanged by these metadata deletions.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the repository's Community Applications template and maintainer profile files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5ceeda03-04a1-43e8-8868-256b64e813a1
Commits

Reviewing files that changed from the base of the PR and between e4531a8 and c3c6cd5.

Files selected for processing: 2

  • FanctrlPlus2.xml
  • ca_profile.xml
Files with no reviewable changes: 2

  • ca_profile.xml
  • FanctrlPlus2.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: c3c6cd5d56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@andrebrait
andrebrait merged commit a0777c9 into main Nov 9, 2026
2 checks passed
@andrebrait
andrebrait deleted the chore/drop-ca-template branch November 9, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant