fix(material/chips): adds border on chip-action focus - #30961
Closed
essjay05 wants to merge 4 commits into
Closed
Conversation
essjay05
requested review from
adolgachev and
wagnermaciel
and removed request for
a team
April 26, 2025 01:24
andrewseguin
added
the
dev-app preview
essjay05
marked this pull request as draft
April 29, 2025 16:08
|
Deployed dev-app for 3a3a1ab to: https://ng-dev-previews-comp--pr-angular-components-30961-dev-08azfdee.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
marked this pull request as ready for review
April 29, 2025 16:19
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
2 times, most recently
from
April 29, 2025 17:30
070a725 to
1b1cfe7
Compare
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
from
May 8, 2025 16:31
1b1cfe7 to
8440748
Compare
wagnermaciel
reviewed
May 8, 2025
wagnermaciel
approved these changes
May 9, 2025
adolgachev
approved these changes
May 12, 2025
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
from
May 13, 2025 20:54
eeb2235 to
efdf78b
Compare
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
2 times, most recently
from
May 21, 2025 23:36
f87e3c9 to
b37ca74
Compare
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
3 times, most recently
from
June 4, 2025 23:43
0351e46 to
bd9f63d
Compare
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
from
June 24, 2025 15:48
bd9f63d to
116801e
Compare
Updates Angular Material Chips component so that when mat-mdc-chip-action is focused on a border appears around either the text of the chip or the action icon, whichever is being focused. This improves the accessibility by aiding the user in seeing which element/action is being focused on. Fixes b/286103414
Removes trailing whitespace to fix lint error.
Updates previous change to set default border color to
Updates previous changes to disable lint errors.
essjay05
force-pushed
the
chip-icon-focus-add-border
branch
from
July 23, 2025 21:10
116801e to
3a3a1ab
Compare
Contributor
|
Closing in favor of #31828 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Angular Material Chips component so that when mat-mdc-chip-action is focused on a border appears around either the text of the chip or the action icon, whichever is being focused. This improves the accessibility by aiding the user in seeing which element/action is being focused on.
Before fix screencast
After fix screencast
Fixes b/286103414