Add test for CardBrowserFragmentViewModel.openDeckSelectionDialog - #21434
Open
GuTS805 wants to merge 1 commit into
Open
Add test for CardBrowserFragmentViewModel.openDeckSelectionDialog#21434GuTS805 wants to merge 1 commit into
GuTS805 wants to merge 1 commit into
Conversation
Covers the default usage: calling openDeckSelectionDialog() emits from flowOfSearchForDecks. Verified via mutation testing that removing the emit breaks the test. Fixes part of ankidroid#13283
Contributor
|
Snapshot diff report vs
All 2 changed screenshotsDeckPickerScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the default usage: calling openDeckSelectionDialog() emits from flowOfSearchForDecks.
Verified via mutation testing that removing the emit breaks the test.
Fixes part of #13283
Purpose / Description
CardBrowserFragmentViewModel.openDeckSelectionDialoghad no test coverage(
@NeedsTest("default usage")). This is another item from the #13283 tracker — only this singlemethod is covered here, per the maintainer's stated preference to keep PRs to one test at a time.
Approach
Added
CardBrowserFragmentViewModelTestusing Turbine to verify that callingopenDeckSelectionDialog()causesflowOfSearchForDecksto emit a value.How Has This Been Tested?
Ran the new test in isolation and confirmed it fails when the emit is removed from
openDeckSelectionDialog()(mutation test: temporarily removedflowOfSearchForDecks.emit(Unit),confirmed the test failed with a Turbine timeout, then reverted). Also ran the full
com.ichi2.anki.browser.*test package with no regressions.Checklist