test: add gh-pin pre-commit - #447
Conversation
|
This is a test run that I ran in embedding example repo |
RobPasMue
left a comment
There was a problem hiding this comment.
I like it! I just see a few issues JSYK, but maybe we can document this. And solve/improve the logic-related ones
| # Constants | ||
| # --------------------------------------------------------------------------- | ||
|
|
||
| _GITHUB_API = "https://api.github.com" |
There was a problem hiding this comment.
This is going to fail on pre-commit.ci... pre-commit.ci has no access to the web.
There was a problem hiding this comment.
https://results.pre-commit.ci/run/github/627525284/1782166214.Op1Xr2HgRWKkTFLLOsqXNA
this was with the branch and commits at the time you commented this. Does this mean pre-commit ci will not have any issues ?
There was a problem hiding this comment.
Hmm interesting.. seems like they changed something and now pre-commit.ci might have access to the web.
There was a problem hiding this comment.
Can you give it a try so that the hook "fails" (i..e. it detects actions that need to be pinned down and have pre-commit.ci change them)
There was a problem hiding this comment.
if pre-commit,ci is unable to access internet then silently passes gh-pin check. May be it might bot be effective with pre-commit.ci but its really helpful doing local commit.
Thank you. I will rectify the issues and thank you for the valuable feedbacks. |
|
I see this branch is still in draft mode ... let us know when we can review it |
Add
ghaction-pinpre-commit hookAdds a new hook that automatically pins GitHub Actions
uses:references from mutable tags to immutable commit SHAs, improving supply-chain security.Before:
After:
What it does
uses:lines missing a ref entirelyUsage