Repository navigation
fix(pi): declare each model's context window in Pi models.json - #106
Merged
Merged
Conversation
Pi defaults to 128k unless an entry sets contextWindow. Write contextWindow and maxTokens from the catalog context_length and top_provider.max_completion_tokens. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: Duyet Le <me@duyet.net> Co-authored-by: duyetbot <bot@duyet.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Root cause: src/spawn.rs
pi_models_configwrote{"id"}only, so Pi assumed 128k for every model. Now writescontextWindow(catalogcontext_length) andmaxTokens(top_provider.max_completion_tokens).Before/after for minimax/minimax-m3.1-flash: 128000 -> 1000000 window, maxTokens 524288. Tests: models.json carries both; parser reads max_completion_tokens. cargo test + clippy green.
Separate from #102 (Claude
[1m]window) and the Rust-CLI claude path; no overlap.🤖 Generated with Claude Code