Skip to content

ATLAS-5342: Atlas React UI: Entity modification functionalities (Add Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities - #697

Open
Brijesh619 wants to merge 6 commits into
apache:masterfrom
Brijesh619:ATLAS-5342

Conversation

@Brijesh619

@Brijesh619 Brijesh619 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Disabled/hide all modification action buttons (Add, Edit, Delete) for Classifications, Terms, Labels, User-Defined Properties, and Business Metadata when the entity status is DELETED or PURGED.
  • Switched the action-link prompt messages (e.g., "To add, click here") to static text under the DELETED/PURGED states.
  • Utilized the isEntityModificationAllowed utility consistently across components to centralize the status-checking logic (replacing direct checks against the EntityStatus enum).
  • Safeguarded button rendering against loading states to prevent UI flashing before the API response resolves.

How was this patch tested?

  • Unit Tests: Added extensive negative test cases to mirror DELETED and PURGED states across all affected components (EntityDetailPage, DetailPageAttributes, ClassificationsTab, AttributeProperties, ShowMoreView, DrawerBodyChipView). Ran the full frontend unit test suite (npm run test) successfully.
  • Build Compilation: Ran typechecking (npm run build / tsc) to ensure strict type safety and verify that all unused enum imports were resolved.

@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-07-16 17-03-01

@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-07-16 17-05-26

@Brijesh619
Brijesh619 force-pushed the ATLAS-5342 branch 2 times, most recently from f1677f7 to e5ed497 Compare July 17, 2026 06:58
@pawarprasad123
pawarprasad123 self-requested a review July 17, 2026 10:55

@pawarprasad123 pawarprasad123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check test case and test coverage after the changes.

Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx Outdated
@Brijesh619
Brijesh619 force-pushed the ATLAS-5342 branch 2 times, most recently from c3879fc to 6ab8d6e Compare July 31, 2026 07:34
@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-07-31 14-35-12

Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/ClassificationsTab.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailPage.tsx Outdated
Comment thread dashboard/src/views/DetailPage/DetailPageAttributes.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/AttributeProperties.tsx Outdated
Comment thread dashboard/src/components/ShowMore/DrawerBodyChipView.tsx Outdated
Comment thread dashboard/src/utils/EntityStatus.ts Outdated
Comment thread dashboard/src/components/EntityDisplayImage.tsx Outdated
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-08-13 16-59-41

Comment thread dashboard/src/utils/EntityStatus.ts
Comment thread dashboard/src/components/__tests__/EntityDisplayImage.test.tsx
Comment thread dashboard/src/views/DetailPage/EntityDetailPage.tsx Outdated
Comment thread dashboard/src/views/__tests__/EntityDetailPage.test.tsx
Comment thread dashboard/src/utils/EntityStatus.ts
Comment thread dashboard/src/components/ShowMore/ShowMoreView.tsx
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-08-14 15-59-29

Comment thread dashboard/src/components/ShowMore/DrawerBodyChipView.tsx Outdated
Comment thread dashboard/src/components/ShowMore/ShowMoreView.tsx Outdated
Comment thread dashboard/src/views/DetailPage/DetailPageAttributes.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailPage.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/AttributeProperties.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/ClassificationsTab.tsx Outdated
Comment thread dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx Outdated
Comment thread dashboard/src/components/__tests__/EntityDisplayImage.test.tsx
Comment thread dashboard/src/styles/propertiesTab.scss
…Classifications, Terms, Labels, Business Metadata) remain active for DELETED entities
@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-08-17 19-29-33 Screenshot from 2026-08-17 19-31-10

@pawarprasad123 pawarprasad123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants