[AURON #2453] Fix filtered aggregation for groups with no matching rows - #2454
Open
lyne7-sc wants to merge 2 commits into
Open
[AURON #2453] Fix filtered aggregation for groups with no matching rows#2454lyne7-sc wants to merge 2 commits into
lyne7-sc wants to merge 2 commits into
Conversation
slfan1989
approved these changes
Aug 7, 2026
slfan1989
left a comment
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The fix ensures that every discovered group has initialized accumulator slots before aggregate filters are applied, preserving the correct empty-input state for filtered aggregates. The regression coverage for both SUM and COUNT looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2453
Rationale for this change
A grouped aggregate may have no rows matching its
FILTERclause. In this case, the group exists but its accumulator may not be initialized, causing an index-out-of-bounds error while producing the result.What changes are included in this PR?
SUMandCOUNT.Are there any user-facing changes?
Yes, bug fix only.
How was this patch tested?
Yes, added regression tests for filtered
SUMandCOUNT.Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: gpt-5ASF guidance: https://www.apache.org/legal/generative-tooling.html