fix: preserve concat binary string bytes - #5267
Open
manuzhang wants to merge 1 commit into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4180.
Rationale for this change
spark.sql.function.concatBinaryAsString=truemakes Spark insertBinaryType-to-StringTypecasts beforeconcat. Spark preserves malformed bytes in those casts, while Comet's native Arrow string path normalizes them to UTF-8 replacement bytes. For example, Spark keepsFFFE41, but Comet producedEFBFBDEFBFBD41.What changes are included in this PR?
concattrees containingBinaryType-to-StringTypecasts through Spark's generated code inside the Comet pipeline.How are these changes tested?
make coreCometSqlFileTestSuite concat_binary_as_stringon Spark 3.4.3, 3.5.8, 4.0.2, and 4.1.2CometCodegenSuite concatBinaryAsStringon the same versions./mvnw spotless:check -Pspark-4.1 -Pjdk17 -DskipTests -Dscalastyle.skip=true