Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft implements the rough consensus from the TCK discussion for cross-project review.
XXH64(row_index.to_le_bytes(), base_seed)and use XXH64 for item hashes.(hash >> 1) % num_buckets.Compatibility
New sketches serialize as version 2. Legacy Rust version 1 images remain readable and retain version 1 when reserialized, so their counters are not mislabeled as using the new hash scheme.
Version 1 images from other implementations remain unreliable for queries, updates, and merges because the image does not identify their legacy row-seed derivation. Existing C++ version 1 snapshots continue to be covered for deserialization and byte round-tripping.
Cross-language version 2 TCK snapshots and byte comparisons still need to be added after the format details are agreed across implementations.
Refs: apache/datasketches-tck#18
Refs: #297
Validation
cargo x checkcargo x prepare-testdatacargo x testcargo x lint