Repository navigation
refactor(countmin): encapsulate bucket count state - #301
Merged
Merged
Conversation
tisonkun
commented
Oct 24, 2026
Member
Author
There was a problem hiding this comment.
I'll push a follow-up for change the estimated_size impl for mainly heap size.
Member
Author
|
Review after commit is welcome. I'm glad to accept any better writing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #300 (comment).
Summary
BucketCountto keep the bucket count and its precomputed remainder multiplier together.BucketCount::index.Trade-off
On the current 64-bit target, nesting the
u32count andu128multiplier increasesCountMinSketchfrom 96 to 112 bytes because the outer type cannot reuse the nested type's tail padding. Under main's existing inline-plus-heap convention, this also increasesestimated_size()by 16 bytes per sketch. #302 independently makesestimated_sizeimplementation-dependent; its current Count-Min implementation excludes this inline overhead.Validation
cargo x checkcargo x testcargo x lint