Repository navigation
chore: update Go snapshots to include HLL compact flag fix - #10
Merged
Merged
Conversation
Move the Go snapshot pin from ad31bdd to 757a485, the merge of apache/datasketches-go#180, and regenerate the Go snapshots. HLL_6 and HLL_8 compact images now set the compact flag like C++ and Java, which fixes the byte mismatch reported in apache/datasketches-go#185. 757a485 is used instead of main because the Go snapshot generator on main currently fails in the theta and tuple packages. The regeneration also adds the aos_multikey and aos_unicode Go snapshots, which the generator already produced at the previous pin but which were missing from the corpus. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tisonkun
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the Go snapshot pin from
ad31bddto757a485(the merge of apache/datasketches-go#180) and regenerateserialization/go/snapshots.Why
Fixes the byte mismatch reported in apache/datasketches-go#185. At
ad31bdd, Go'sToCompactSlice()for HLL_6 and HLL_8 did not set the compact flag, so preamble byte 5 was0x00where C++ and current Java write0x08. apache/datasketches-go#180 fixed this, following apache/datasketches-java@9a488f9.757a485is used instead of Gomainbecause the Go snapshot generator onmaincurrently fails in the theta and tuple packages: since apache/datasketches-go#181, updates that theta legitimately screens out are asserted as errors. With that fixed,maingenerates the same deterministic snapshots as757a485.Snapshot changes
hll6_n{1000,10000,100000,1000000}_go.skandhll8_n{1000,10000,100000,1000000}_go.skdiffer only at byte 5 (0x00→0x08).aos_multikey_n*_go.skandaos_unicode_go.sk. The Go generator already produced these at the previous pin, but they were never added when 9438efd removed the oldaos_multi_key_*andaos_unicode_stringsnames. The new names match the C++ and Java snapshots.Checks run locally
mise run tck -- snapshots check go: the file set and all deterministic snapshots reproduce; only probabilistic snapshots differ.mise run check: passes.HllSketchCrossLanguageTest(all test groups), using the C++ and Go snapshots from this branch: 7/7 pass, so all 24 HLL snapshots are byte-identical across C++, Go and Java. With the snapshots from datasketches-java's currently pinned TCK revision,checkBinaries2andcheckBinaries3fail as reported in HLL6 Binary differences between C++ vs Go and Java vs Go. datasketches-go#185.Follow-up
For datasketches-java's cross-language tests to pick this up,
TCK_REVISIONintools/download_serialization_test_data.sh(currentlyd363b12) needs to move to this change once merged.🤖 Generated with Claude Code