Skip to content

FINERACT-2455: Working Capital Loan Charge-Off - #6143

Merged
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-charge-off
Aug 4, 2026
Merged

FINERACT-2455: Working Capital Loan Charge-Off#6143
adamsaghy merged 3 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-charge-off

Conversation

@alberto-art3ch

Copy link
Copy Markdown
Contributor

Description

Brings Charge-Off to the Working Capital Loan module

  • New chargeOff / undoChargeOff transaction commands on /working-capital-loans/{id}/transactions, wired through the legacy command pipeline (audit trail + maker-checker).
  • Charge-off marks the loan as charged-off and creates a non-monetary CHARGE_OFF transaction recording the outstanding balance. The tag is only removed by an explicit undo.
  • Validations: single charge-off only, date not before the last transaction and not in the future, undo only when no monetary transaction follows the charge-off, and no new charges allowed after charge-off.
  • Exposes chargedOff on the loan read model and a charge-off template (auto-calculated amount + date + reason options).

FINERACT-2455

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-charge-off branch 10 times, most recently from 66a05c7 to ef2d521 Compare July 23, 2026 02:31
@alberto-art3ch
alberto-art3ch marked this pull request as ready for review July 23, 2026 02:33
@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-charge-off branch 2 times, most recently from 6eac8a9 to 02ec8e9 Compare July 23, 2026 18:08
Comment thread fineract-doc/src/docs/en/chapters/features/working-capital-charge-off.adoc Outdated
Comment thread .gitignore Outdated
@adamsaghy

Copy link
Copy Markdown
Contributor
    /home/runner/work/fineract/fineract/fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanChargeOffWriteServiceImpl.java:104: error: method forPortions in class WorkingCapitalLoanTransactionAllocation cannot be applied to given types;
            final WorkingCapitalLoanTransactionAllocation allocation = WorkingCapitalLoanTransactionAllocation.forPortions(chargeOffTransaction,
                                                                                                              ^
      required: WorkingCapitalLoanTransaction,BigDecimal,BigDecimal,BigDecimal,BigDecimal
      found:    WorkingCapitalLoanTransaction,BigDecimal,BigDecimal,BigDecimal
      reason: actual and formal argument lists differ in length
    1 error
  

@adamsaghy

Copy link
Copy Markdown
Contributor

@alberto-art3ch Hmm... something went sideways here... way too many commits :/

@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-charge-off branch from 7ff52c9 to 445db7b Compare August 3, 2026 15:06
@alberto-art3ch

Copy link
Copy Markdown
Contributor Author

@alberto-art3ch Hmm... something went sideways here... way too many commits :/

Done! I've fixed this

@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-charge-off branch from 445db7b to 69b0228 Compare August 3, 2026 15:16
@alberto-art3ch
alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-charge-off branch 2 times, most recently from 070624d to fd9a343 Compare August 3, 2026 17:55
@adamsaghy
adamsaghy force-pushed the FINERACT-2455/working-capital-loan-charge-off branch from ae3030e to 21d4d08 Compare August 4, 2026 10:03

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit e201c03 into apache:develop Aug 4, 2026
91 checks passed
@adamsaghy
adamsaghy deleted the FINERACT-2455/working-capital-loan-charge-off branch August 4, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants