FINERACT-2716: Log SMS campaign preview JSON parsing failure instead of silently swallowing it - #6190
Conversation
|
hey @adamsaghy please trigger checks whenever possible, thanks! |
|
hey @adamsaghy , failures look flaky, can you please retrigger those checks? thanks a lot! |
|
Sorry for the ping @adamsaghy . I think this is ready for review ! |
|
Hi @adamsaghy, sorry for the additional ping. When you get a chance, could you please review this PR? Thank you! |
|
Hey @adamsaghy This looks ready to merge whenever you get a chance. Let me know if anything else is needed. |
|
Understood @adamsaghy I'll update this to throw instead. |
…of silently swallowing it
8b31a56 to
8ca98ea
Compare
|
hey @adamsaghy Updated the fix to throw a PlatformDataIntegrityException instead of just logging, following the existing convention used elsewhere in the codebase. |
|
Hey @adamsaghy , failure is unrelated to my code . Please retrigger that check whenever possible, thanks a lot! |
|
hey @adamsaghy please let me know if this is the correct approach. |
3 participants
JIRA
https://issues.apache.org/jira/browse/FINERACT-2716
Problem
The previewMessage-equivalent method in SmsCampaignWritePlatformServiceJpaImpl
caught IOException from JSON parsing and did nothing with it. No log, no
rethrow. The failure disappeared silently.
Fix
Replaced the // TODO throw something here with a log.error call. This was the
last remaining instance of this pattern in the class - every other
catch (IOException ...) block here already logs and continues.
This is a direct follow-up to FINERACT-2707, which fixed the equivalent issue
in EmailCampaignWritePlatformCommandHandlerImpl, and to the note left in that
PR flagging this exact method as the one remaining spot.
I also grepped the full codebase for "TODO throw something here" and for any
other silent catch (IOException e) {} blocks - this was the only remaining
occurrence; everything else already logs.
No functional change otherwise.