FINERACT-2724: Allocate Cash - Adjust the error message when amount is not an integer - #6203
Open
rymghosn wants to merge 2 commits into
Open
Conversation
rymghosn
force-pushed
the
port/CBS-284-allocate-cash-amount-error-message
branch
from
July 30, 2026 15:11
7968a24 to
b77a954
Compare
…ash amount is not numeric Signed-off-by: Rym.Ghosn <rym.ghosn@foo.mobi>
rymghosn
force-pushed
the
port/CBS-284-allocate-cash-amount-error-message
branch
from
July 31, 2026 05:57
b77a954 to
fc447ad
Compare
adamsaghy
reviewed
Aug 3, 2026
adamsaghy
requested changes
Aug 3, 2026
adamsaghy
left a comment
adamsaghy
left a comment
Contributor
There was a problem hiding this comment.
Kindly review my concerns.
…or via Jackson's exception mapper Reviewer feedback on PR apache#6203 correctly flagged that changing txnAmount from BigDecimal to String is a breaking API/Swagger change (and broke run-api-backward-compatibility). Revert that DTO/Swagger change and the now-unreachable try/catch in TellerCommandFromApiJsonDeserializer, and instead teach HttpMessageNotReadableErrorController to recognize a Jackson InvalidFormatException on a numeric field and return a clear, field-specific "not a valid number" validation error. This fixes the original unclear-error report without any breaking API change, and applies to numeric fields platform-wide rather than just this endpoint. Also fixes a spotless line-wrap violation introduced by the original commit. Signed-off-by: Rym.Ghosn <rym.ghosn@foo.mobi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The teller cashier "allocate cash" endpoint (POST /tellers/{tellerId}/cashiers/{cashierId}/allocate) returned an unclear/generic error when
txnAmount was not a valid number, instead of a proper validation message.
Changes made:
a malformed value reaches the deserializer instead of failing earlier at JSON-binding time.
with a clear "Amount must be a number" message, reusing the existing validation.msg.invalid.decimal.format error code.
This PR( https://issues.apache.org/jira/browse/FINERACT-2724 )