Repository navigation
Improve input type errors with consumer annotations - #1768
Open
YashAnand69 wants to merge 1 commit into
Open
YashAnand69 wants to merge 1 commit into
YashAnand69 wants to merge 1 commit into
Conversation
Show each consuming node and its declared input annotation when runtime input validation fails. Preserve validation and execution behavior. Assisted-by: OpenAI Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an external input has consumers with different compatible annotations, the runtime type error only reports the merged input type. Include each consuming node and its declared annotation so the source of that expectation can be traced.
Related #1180.
Changes
Append deterministic consumer names and annotations to an existing input-type mismatch error. Successful execution and validation decisions are unchanged.
How I tested this
A broader graph-inclusive run had 335 passes and five failures because the native Graphviz
dotexecutable is unavailable locally; those rendering checks are not claimed to pass.Notes
This addresses the diagnostic improvement proposed in the issue. It does not change merged-type selection: the original example can accept an invalid value depending on function discovery order. It also does not change visualization or internal-node runtime validation.
Codex assisted with investigation, implementation, tests and independent agent review.
Checklist