Fix flaky L1 priority queue blocking test - #18364
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a timing race in
L1PriorityQueueTest.testPollBlockedobserved in an unrelated Windows unit-test job.The test slept for a fixed 100 ms before checking the worker thread state. On a loaded runner, the worker could still be
RUNNABLE, even thoughL1PriorityQueue.poll()blocks correctly once it reaches the empty queue.Use Awaitility with a bounded timeout for both the
WAITINGandTERMINATEDstates. This matches the existing synchronization pattern inL2PriorityQueueTestandMultilevelPriorityQueueTest.Tests
mvn '-Ddevelocity.off=true' -pl iotdb-core/datanode -am '-Dtest=L1PriorityQueueTest' '-Dsurefire.failIfNoSpecifiedTests=false' testThis PR has: