Skip to content

[Pipe] Fix procedure diagnostic Sonar issues - #18366

Open
Caideyipi wants to merge 2 commits into
apache:masterfrom
Caideyipi:fix/pipe-procedure-diagnostic-sonar
Open

[Pipe] Fix procedure diagnostic Sonar issues#18366
Caideyipi wants to merge 2 commits into
apache:masterfrom
Caideyipi:fix/pipe-procedure-diagnostic-sonar

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Description

Follow-up to #18297.

  • Replace volatile mutable diagnostic references with AtomicReference.
  • Preserve the live pending-DataNode view backed by ConcurrentHashMap.keySet().
  • Make the non-null state contract explicit before state switches.
  • Parameterize LockQueue so its owner getter no longer exposes a wildcard type.
  • Use pattern matching and a Checkstyle-compatible switch layout.
  • Document the no-op tracker and suppress unavoidable line-length warnings caused by generated i18n identifiers.

Tests

  • mvn -pl iotdb-core/confignode -Dtest=AbstractOperatePipeProcedureV2Test,TestLockRegime -Ddevelocity.off=true test (7 tests)
  • mvn -pl iotdb-core/confignode checkstyle:check
  • mvn -pl iotdb-core/confignode spotless:apply
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant