Skip to content

[Fix] Address aligned memory accounting Sonar issues - #18372

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/aligned-memory-sonar
Open

[Fix] Address aligned memory accounting Sonar issues#18372
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/aligned-memory-sonar

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

This is a follow-up to #18330. Sonar reported 14 issues in the aligned memory accounting changes.

This PR:

  • removes six redundant long casts and groups the overloaded memory-cost methods;
  • normalizes TvList naming in the reconciliation snapshot and helper;
  • documents and narrowly suppresses complexity in stateful write/scan hot paths, plus the tablet helper parameter count.

These changes do not alter runtime behavior.

Verification

  • AlignedTVListTest: 15 passed
  • TsFileProcessorTest: 20 passed
  • DataNode main and related test sources compiled
  • Checkstyle: 0 violations
  • Spotless and git diff --check: passed

This PR has:

  • been self-reviewed.
  • added comments explaining the targeted Sonar suppressions.
  • been covered by existing unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant