Skip to content

[Fix] Address TsFile scan parser Sonar issues - #18374

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/tsfile-scan-parser-sonar
Open

[Fix] Address TsFile scan parser Sonar issues#18374
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/tsfile-scan-parser-sonar

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

This is a Sonar follow-up to #18305 and #18350. Sonar reported two brain-method warnings in the TsFile scan parser.

The affected methods are the parser hot paths for:

  • aligned/scalar value-type dispatch;
  • TsFile marker transitions and chunk-reader state.

This PR documents and narrowly suppresses those two warnings. Splitting either method would spread state-machine context across extra calls; parser behavior is unchanged.

Verification

  • TsFileInsertionEventParserTest: 21 run, 0 failures, 0 errors, 3 existing conditional skips
  • DataNode compilation: passed
  • Checkstyle: 0 violations
  • Spotless and git diff --check: passed

This PR has:

  • been self-reviewed.
  • added comments explaining the targeted Sonar suppressions.
  • been covered by the existing parser unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant