Pipe: Fix concurrent TsFile reference increases - #18376
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PipeTsFileResourceManager.increaseFileReferencechecked whether a resource existed before entering the creation critical section. Historical and realtime extractors could both observe a missing resource, then create and put separatePipeTsFileResourceinstances for the same hardlink. The later put overwrote the first reference count, so releasing one event could delete a hardlink that another event still needed and stop the pipe withFileNotFoundException.This change rechecks the resource map after acquiring the segment lock. If another caller has already created the resource, it increments and reuses that resource instead of overwriting it.
A concurrent regression test starts 64 retain operations together and verifies that both the pipe-private and shared reference counts reach 64, then verifies complete cleanup after all releases. Before the fix, the test reproduced a lost count (
expected: 64, actual: 58); with the fix, the full test class passes.Validation:
mvn -pl iotdb-core/datanode -Ddevelocity.off=true -Dtest=PipeTsFileResourceManagerTest testmvn -pl iotdb-core/datanode -Ddevelocity.off=true spotless:checkmvn -pl iotdb-core/datanode -Ddevelocity.off=true checkstyle:checkgit diff --checkThis PR has:
Key changed/added classes
PipeTsFileResourceManagerPipeTsFileResourceManagerTest