Repository navigation
Replace utility calls with the JDK, modernize tests, tidy POMs and simplify code - #1028
Open
slachiewicz wants to merge 11 commits into
Open
slachiewicz wants to merge 11 commits into
slachiewicz wants to merge 11 commits into
Conversation
A constructor reference resolves the class before identitiesFrom can catch a missing JNA class, so it defeats the guard and breaks SSH agent tests when JNA is absent.
Use a reverse-order Files.walk with bounded retries for DirectoryNotEmptyException and AccessDeniedException so fixture teardown tolerates file handles still held by tests.
slachiewicz
force-pushed
the
plexus-utils-to-jdk
branch
from
November 19, 2026 20:51
1014c79 to
3041479
Compare
…bbit Replace the remaining org.codehaus.plexus.util usages with JDK equivalents: - FileWagon: local recursive copy via Files.copy/nio, replacing FileUtils.copyDirectoryStructure - WebDavWagon: local path normalize helper replacing FileUtils.normalize - PathNavigator: StringTokenizer replacing StringUtils.split - HugeFileDownloadTest: Files.copy(Path, OutputStream) replacing IOUtil.copy Remove the plexus-utils dependency from the three module POMs.
plexus-utils 4.1.0 brought by sisu has InterpolationFilterReader but not the XML reader classes the Plexus container loads; plexus-xml 3.0.1 supplies those.
slachiewicz
marked this pull request as ready for review
November 19, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical cleanups in separate commits (POM cleanup, static analysis, plexus-utils to JDK, tests), generated with OpenRewrite.
Classes made final:
CommandExecutorStreamProcessor,HandlerRequestResponse.Verified:
mvn verify→ the same 1054 test cases as on master.