Skip to content

Replace utility calls with the JDK, modernize tests, tidy POMs and simplify code - #1028

Open
slachiewicz wants to merge 11 commits into
apache:masterfrom
slachiewicz:plexus-utils-to-jdk
Open

slachiewicz wants to merge 11 commits into
apache:masterfrom
slachiewicz:plexus-utils-to-jdk

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

Mechanical cleanups in separate commits (POM cleanup, static analysis, plexus-utils to JDK, tests), generated with OpenRewrite.

Classes made final: CommandExecutorStreamProcessor, HandlerRequestResponse.

Verified: mvn verify → the same 1054 test cases as on master.

A constructor reference resolves the class before identitiesFrom can catch a missing JNA class, so it defeats the guard and breaks SSH agent tests when JNA is absent.
Use a reverse-order Files.walk with bounded retries for DirectoryNotEmptyException and AccessDeniedException so fixture teardown tolerates file handles still held by tests.
…bbit

Replace the remaining org.codehaus.plexus.util usages with JDK equivalents:
- FileWagon: local recursive copy via Files.copy/nio, replacing FileUtils.copyDirectoryStructure
- WebDavWagon: local path normalize helper replacing FileUtils.normalize
- PathNavigator: StringTokenizer replacing StringUtils.split
- HugeFileDownloadTest: Files.copy(Path, OutputStream) replacing IOUtil.copy
Remove the plexus-utils dependency from the three module POMs.
plexus-utils 4.1.0 brought by sisu has InterpolationFilterReader but not the XML reader classes the Plexus container loads; plexus-xml 3.0.1 supplies those.
@slachiewicz
slachiewicz marked this pull request as ready for review November 19, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant