Repository navigation
[core] Support logical Arrow keys and selected upsert values - #1147
Merged
JingsongLi merged 5 commits intoOct 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Expand Native row-level updates for Arrow input shapes already supported by PyPaimon. This covers action-specific upsert payload conversion, lossless logical key matching, and Dictionary keys in MERGE. Matching and conversion stay in Rust core; the Python bridge only qualifies supported inputs and transports batches.
Brief change log
normalize_match_keyhelper; logical type and NULL matching rules remain operation-specific. No new public API or dependencies.Tests
cargo +1.98.0 test --locked -p paimon --lib key_normalization: 5 passed.cargo +1.98.0 test --locked -p paimon --lib upsert: 10 passed.cargo +1.98.0 test --locked -p paimon --lib table_merge_into_tests: 17 passed.cargo +1.98.0 test --locked -p paimon --lib table::update_input: 29 passed.cargo +1.98.0 test --locked -p paimon --lib table::data_evolution_writer: 19 passed.cargo +1.98.0 test --locked -p paimon --lib table::write_batch_normalize: 24 passed.cargo +1.98.0 clippy --locked -p paimon --lib --tests -- -D warnings.cargo +1.98.0 fmt --all -- --checkandgit diff --check.Coverage includes batch/stream upserts, last-write-wins across chunks, fan-out, partition isolation, NULL indices and NULL dictionary values, discarded invalid payloads, strict append validation, precision/overflow failures, Binary/LargeBinary conversion parity, Dictionary MERGE update/insert/delete/cardinality, and Pandas categorical input.
The companion apache/paimon#10629 also enables existing core Parquet vector/BLOB update support across row-ID, incremental, predicate, upsert, MERGE, and shard operations, with Python/Native parity coverage. Its Native CI requires this PR on Rust main.
API and Format
No public API or storage format change. Existing core row-ID conversion rules and Java-compatible write/file metadata semantics are reused.
Documentation
Clarified
TableUpdate::upsert_by_arrow_with_keymatched conversion and append-validation contracts and documented logical key normalization internally.Follow-up review fixes