Repository navigation
[core] Fix VARIANT timestamp projection and scalar conversions - #1151
Merged
JingsongLi merged 1 commit intoOct 18, 2026
Merged
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
October 17, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix incorrect VARIANT timestamp projections, missing Boolean-to-numeric casts, and decimal shredding overflow.
Brief change log
Tests
Parquet round-trip regressions cover plain/shredded VARIANT, timestamp units and overflow, Boolean casts, and decimal residuals.
cargo test -p paimon --lib variant: 93 passed.cargo test -p paimon --lib arrow::shredding: 49 passed (overlapping coverage).cargo fmt --all -- --checkandgit diff --checkpassed.API and Format
No public API or storage format changes.
Documentation
Not required for these correctness fixes.