feat: Add unpersistent versions of persistent behaviors (#2456) - #2465
Merged
Conversation
He-Pin
force-pushed
the
1.3.x-unpersistence
branch
from
November 9, 2025 12:47
554a13c to
22c06e4
Compare
Member
Author
|
Finally, the last one~ |
He-Pin
force-pushed
the
1.3.x-unpersistence
branch
from
November 9, 2025 14:05
22c06e4 to
4fd8f91
Compare
(cherry picked from commit 523c05f)
He-Pin
force-pushed
the
1.3.x-unpersistence
branch
from
November 9, 2025 14:27
4fd8f91 to
e98f8ff
Compare
Member
|
@mdedetrich what do you think about the class names? I think NonPersistent would be a better name. |
Member
|
Unpersist means to undo a persist action. Non-Persistence is a better way to describe a persistence approach which doesn't really use physical persistence but that creates a dummy implementation useful for tests. |
Member
Author
|
I agree, non persistent seems better. |
Member
Author
|
@pjfanning I don't have a computer by my side, would you mind submit a pr to do the renaming ？ |
Member
|
Let's see what people think about the name. If NonPersist has doubts, we could just go for a more neutral name prefixed with Testkit or some such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 523c05f)