Update OnMessageIntroTest.java - #2492
Merged
Merged
Conversation
pjfanning
commented
Nov 13, 2025
pjfanning
commented
Member
- copies over some of the changes from Java 17 changes in OnMessageIntroTest.java #2491
- we still need to compile in Java 8 in 1.3.x but this brings some of the comments and commented out code examples up to date
pjfanning
marked this pull request as draft
November 13, 2025 14:27
He-Pin
approved these changes
Nov 13, 2025
He-Pin
reviewed
Nov 13, 2025
| * } | ||
| * | ||
| * Java 17 onward: JEP 406 (https://openjdk.org/jeps/406) => | ||
| * Java 21 onward: JEP 441 (https://openjdk.org/jeps/441 => |
Member
There was a problem hiding this comment.
actually， this can be used in Java 17 too, just lack some features.
Member
Author
There was a problem hiding this comment.
- our existing docs have a section about pattern matching in Java but say Java 21 is when it was implemented - 441 is a Java 21 JEP
- there were some preview JEPs before that but my experience is that orgs are reluctant to set the preview flag when running Java
- it just is easier to say Java 21 than to give a long spiel about when which preview JEP became available when
- anyone who has enabled preview on their JVM will just know anyway - no need to confuse everyone else
Member
There was a problem hiding this comment.
that's true, just jump to Java 21/25
pjfanning
marked this pull request as ready for review
November 13, 2025 16:22
samueleresca
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.