Repository navigation
Fix publish-docker startup_failure and bump x/net, x/crypto, x/text - #237
Merged
Merged
Conversation
…docker login The ASF allow-list expired the docker/login-action v4.2.0 SHA pin, so the workflow failed at startup again after #236 merged (as before in #229 and #231). A plain `docker login --password-stdin` step does the same thing with no third-party pin to expire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUyq3m8dX1W9YceYrZB8yj
Upgrade golang.org/x/net to v0.60.0, golang.org/x/crypto to v0.57.0 and golang.org/x/text to v0.42.0 (x/sync, x/sys and x/term follow). This clears the advisories govulncheck still reports after #236, including five x/net HTTP/2 ones reachable from swctl's HTTP clients. The only remaining finding is GO-2026-5932 (x/crypto/openpgp is unmaintained, has no fix, and is not imported). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUyq3m8dX1W9YceYrZB8yj
mrproliu
approved these changes
Oct 17, 2026
wankai123
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #236:
publish-docker
startup_failure. After #236 merged,publish-dockerfailed at startup (run). The ASF allow-list's "Remove Expired Refs" job dropped thedocker/login-action@650006c6…(v4.2.0) pin. This is the third time this pin has expired (#229, #231). The step now runs a plaindocker login --password-stdinagainst$HUBwithGITHUB_TOKEN. That is the same command the action ran, and there's no third-party pin left to expire. The workflow only runs on pushes tomaster, so merging this also publishes the image that #236 should have produced.Remaining dependency advisories. govulncheck still reported advisories after #236, including five x/net HTTP/2 ones (GO-2026-6603, 6610, 6611, 6612, 6617, fixed in x/net v0.60.0) that are reachable from swctl's HTTP clients. This bumps
golang.org/x/netto v0.60.0,golang.org/x/cryptoto v0.57.0 andgolang.org/x/textto v0.42.0. x/sync, x/sys and x/term move up with them, andgo mod tidychanges thegodirective from1.26to1.26.0.dist/LICENSEis regenerated and CHANGES.md is updated.After the bump, govulncheck reports only GO-2026-5932:
x/crypto/openpgpis unmaintained, has no fix, and swctl doesn't import it.Checked locally:
go mod verify, build, vet, unit tests,make dependency-licenseandlicense-eye header checkpass.🤖 Generated with Claude Code
https://claude.ai/code/session_01LUyq3m8dX1W9YceYrZB8yj