SER-329 Add view certificate logs option - #2318
Conversation
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
WalkthroughAdds a “View logs” action for domain proxy rules in the sites domains table and a new ViewLogsModal component. The domains table imports IconTerminal, Divider, and ViewLogsModal; adds internal state ( Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte (2)
102-113: Guard against empty logs to avoid a no-op action.If logs can be an empty string/array, the button will still appear. Prefer checking length when available.
- {#if rule.logs} + {#if rule.logs?.length} <ActionMenu.Item.Button leadingIcon={IconTerminal} on:click={(e) => { selectedProxyRule = rule; showLogs = true; toggle(e); }}> View logs </ActionMenu.Item.Button> - {/if} + {/if}Optionally, emit an analytics event on click for observability (mirroring Delete).
124-131: Avoid bespoke spacing for dividers (if a native divider exists).If Pink Svelte exposes an ActionMenu-specific divider, prefer it to inline styles for consistency. Otherwise, consider replacing inline styles with design tokens/util classes used elsewhere.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte(5 hunks)src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/viewLogsModal.svelte(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e
- GitHub Check: build
🔇 Additional comments (4)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/table.svelte (3)
6-12: Imports LGTM.IconTerminal, Divider, and ViewLogsModal imports align with usage; no dead imports spotted.
Also applies to: 19-21, 24-24
36-36: State wiring for logs modal looks correct.showLogs is properly initialized and later bound to the modal.
162-164: Modal integration LGTM.Conditional mount and prop binding are correct; lifecycle ordering (set selectedProxyRule before opening) is safe.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/viewLogsModal.svelte (1)
7-13: Please provide the Logs component’s source (e.g. Logs.svelte) or the package’s type definitions/package.json from @appwrite.io/pink-svelte so I can confirm the exactlogsprop type.
| {#if rule.logs || (rule.status !== 'verified' && rule.status !== 'verifying')} | ||
| <div | ||
| style:margin-inline="-1rem" | ||
| style:padding-block-start="0.25rem" |
There was a problem hiding this comment.
Could we wrap this in a class (action-menu-divider) instead of using inline styles?
.action-menu-divider { margin-inline: -1rem; padding-block-start: 0.25rem; padding-block-end: 0.25rem; }

What does this PR do?
Add
View logsif certificate logs are present. Add new modal for view logs.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
New Features
Style