feat: prepare for open source release with KPS v1.2 support - #2
Merged
Conversation
- Add MulanPSL-2.0 LICENSE - Add comprehensive README (English & Chinese) - Add contributing guidelines (English & Chinese) - Add security policy (English & Chinese) - Add code of conduct (English & Chinese) - Add CHANGELOG.md - Add GitHub issue/PR templates - Add CI/CD workflow for testing - Update license in Cargo.toml and pyproject.toml move reader test to tests fmt and fix doc tests prepare for open-sourcing support kps
zhexuany
force-pushed
the
opensource-prep
branch
from
January 20, 2026 16:50
dd3cb5b to
9a0ced6
Compare
- Fix test_factory_no_feature: add cfg guard to only run when kps features disabled - Fix test_map_topic_to_v12_path: check for both "velocity" and "velocities" - Fix dead_code warnings in NvComCompressor and IoUringPrefetcher - Replace manual modulo check with is_multiple_of() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The name TransformPipeline was confusing as it conflicted with the actual processing pipelines (Standard Pipeline, HyperPipeline) in the roboflow crate. The new name MultiTransform better reflects that this is a composite transform that applies multiple metadata transforms (topic rename, type rename) in sequence, not a message processing pipeline. Changes: - Rename TransformPipeline struct to MultiTransform - Update all references across robocodec and roboflow crates - Update documentation and comments Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| let profile_dir = profile_output.parent().unwrap_or(Path::new(".")); | ||
| if !profile_dir.exists() { | ||
| std::fs::create_dir_all(profile_dir)?; | ||
| } |
There was a problem hiding this comment.
Profile command fails with filename-only output path
Medium Severity
When --profile-output is a filename without a directory component (e.g., myprofile), parent() returns Some(Path::new("")) (empty path) rather than None. The unwrap_or(Path::new(".")) doesn't trigger because Some was returned, so profile_dir becomes an empty string. Then create_dir_all("") fails with a confusing error about creating an empty-named directory, rather than correctly defaulting to the current directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.