Repository navigation
docs(retention): retire the list premise both retention gates state - #409
Merged
Merged
Conversation
#406 moved the transactions page onto the `tx_facts` read model, which retired the premise "the list needs per-row identity (`id`/`counterpart`), the roll-up has none, so the list can always only be answered from the detail table". #407's own commit message says its premise "was exactly what #406 removed", and `ui/README.md` calls it the premise that disappeared this round - but the two module docs that state it were never updated, so both still carry it in the present tense. - `src/tx_retention_gate.rs:6-7` opens the rule list with it, so the file argues from a premise that its own bullet, ten lines later, says is gone. - `src/usage_retention_gate.rs:4-5` reasons across files from it, and names the rule wrong as well (that rule was rewritten in #407). Both sentences now say what holds today: the window must be expressible in minutes, and the history outside it is carried by the minute roll-ups. Comments only - no behaviour, no gate rule, no config changes.
argszero
added a commit
that referenced
this pull request
Oct 15, 2026
Bump the manifest and the three deployment carriers from 0.7.32 to 0.7.33, and record the release in CHANGELOG.md. Since v0.7.32 one commit landed (#409): a comment-only change to the two retention gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two module docs state a premise that #406 retired, as if it were still true today.
The premise: the transactions pagination list needs per-row identity (
id/counterpart), the roll-up has none, therefore the list can always only be answered from the detail table. #406 moved the list onto thetx_factsread model (roll-ups ∪ unfolded tail), andcounterpartis not in the payload at all, so the premise no longer holds.The evidence that it was retired deliberately is already in this repository:
ui/README.md, written by feat(rollup): keep ten minutes of transaction detail by default #407, calls it the premise that disappeared this round.Neither of those commits updated the module docs that state it, so both still assert it in the present tense:
src/tx_retention_gate.rs:6-7opens the rule list with it — the file argues from a premise that its own bullet, ten lines later, says is gone.src/usage_retention_gate.rs:4-5reasons across files from it, and names the rule wrong as well: it says "the window must cover every preset the list itself offers", which feat(rollup): keep ten minutes of transaction detail by default #407 rewrote into two halves (the window must be expressible in minutes, or the list no longer reads the detail table).Both sentences now say what holds today: the window must be expressible in minutes, and the history outside it is carried by the minute roll-ups.
Related Issue
None.
Changes
src/tx_retention_gate.rs— the premise sentence is marked as the former premise, with a pointer to the acceptance item that retired it (feat(transactions): serve the transactions list from the tx_facts read model #406).src/usage_retention_gate.rs— the cross-file sentence now states the reason that holds and how the outside-window history is carried.Comments only: no behaviour, no gate rule, no config, no cache-bust token.
Tests
cargo test— 562 passed, 0 failed (identical to the base tree)cargo fmt --check— cleancargo clippy --all-targets -- -D warnings— rc=0Checklist
docs/...)