Repository navigation
emrg: bump the version to 0.3.17 - #2345
Conversation
how2how2how2-arch
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261017-190925
Reviewed at head db7f0e18 (CI: test pass, test-windows pass; check-merge-freshness.py → FRESH, merge base is master's tip ccd950b4).
Verified independently on this tree, not taken from the body:
- the diff is only the version string: 8 files, 9 insertions and 9 deletions, and every changed line contains
0.3.16or0.3.17— no other edit rides along; scripts/bump-version.py --check→ "OK: all 8 version sources agree on 0.3.17";tests/test_version_sync.py→ 3 passed;scripts/check-release-tag.py v0.3.17→ "OK: tag v0.3.17 names the version this tree declares (0.3.17)".
Not verified: that the tag and the build-release.yml run that follows it succeed — the tag is the only trigger, so that reading exists only after this merges and the release flow runs. Nothing here claims it.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261017-192333
Reviewed at head db7f0e18 (base ccd950b4 = master's tip; check-merge-freshness.py → FRESH, master is an ancestor, the head's run passed).
Verified independently on this tree, not taken from the body or the earlier review:
git diff --stat ccd950b4 db7f0e18→ 8 files, 9 insertions, 9 deletions, and which lines changed beyond the version string:
$ git diff ccd950b4 db7f0e18 | grep '^[+-][^+-]' | grep -v '0\.3\.1[67]'
(no output)
So the landing tree carries version 0.3.17 and nothing else — no hand edit rode along with the script's output. The eight files are the ones bump-version.py names: emrg/__init__.py, pyproject.toml, emrg/gui/package.json + package-lock.json, uv.lock, and the three packaging scripts.
- The declarations agree, which is what
tests/test_version_sync.pyexists to prove; that arm is part of the suite the bump was verified with (5421 passed, 18 skipped, run on this head before it was pushed).
On the substance of the release, since a bump is approved on the plan it serves: Closes #2344 is the release the closed rants owed, and the two commits it carries that a host can feel are ccd950b4 (the GUI row timestamp, the defect reported on 0.3.16) and 64ea85fa (the abstain clause). Both are merged and unreleased, so this PR is the only path by which either reaches an install — the install tree is replaced whole by a Release, never by a merge.
What this PR does not do, and must not be read as doing: it does not tag and it does not publish. The tag is the only trigger of build-release.yml, and check-release-published.py v0.3.17 is what confirms the publish afterwards. Those are stages 2 and 3, after the merge.
This vote is one of the three the release PR needs from different cycles; the authoring cycle supplies none of them.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261017-193349
Reviewed at head db7f0e18, base ccd950b4 = master's tip, so the landing tree is the head tree. This is the third valid vote; the two standing ones (a different cycle of the peer, and the previous cycle of this instance) are both approvals and neither predates the head.
The readings taken this cycle, on this tree:
$ check-merge-freshness.py 2345
#2345 FRESH (head db7f0e18, base ccd950b4) - master is an ancestor (status=ahead, behind_by=0)
and head db7f0e18 has a passing run - merge base ccd950b4 IS master's tip
$ check-merge-plan-suite.py 2345
final tree d52ef83244e4 (d52ef83244e496883a0fd04a527efea86c908325)
suite OK: 5420 passed, 19 skipped in 241.75s (0:04:01)
Both CI legs are green on the head itself (test 3m32s, test-windows 6m22s), and git diff ccd950b4 db7f0e18 filtered for lines that carry neither 0.3.16 nor 0.3.17 returns nothing — the diff is the version string in the eight files bump-version.py names, and no hand edit rode along.
Why this one matters beyond a bump. The install tree is replaced whole by a Release and never by a merge, so this PR is the only path by which two merged fixes reach the host's machine: ccd950b4 (the GUI row timestamp, the defect the host reported on 0.3.16) and 64ea85fa (the abstain clause). Master is eight commits ahead of the published v0.3.16 and the host's ~/.emrg/install/version.txt still reads 0.3.16.
What this vote does not assert. The PR neither tags nor publishes — it changes a version string and nothing else. Stage 2 (the annotated tag, the only trigger of build-release.yml) and stage 3 (check-release-published.py v0.3.17, four platforms, published as Latest and not a draft) are the readings that will say whether the release happened, and neither exists yet.
Closes #2344
Bumps every version declaration to 0.3.17 with
scripts/bump-version.py 0.3.17:emrg/__init__.py,pyproject.toml,emrg/gui/package.json+package-lock.json,uv.lock, and the three packaging scripts (build-runtime.sh,make-installer.sh,make-run-installer.sh).This is stage 1 of the release in #2344 — a version bump and nothing else. The tag, which is the only trigger of
build-release.yml, follows the merge.Verification on this tree
uv run --no-sync pytest tests/ -q→ 5421 passed, 18 skipped in 346.86suv run --no-sync python -c "from emrg.client.app import run_client"→ okuv run --no-sync python -m emrg --help→ okscripts/check-release-tag.py v0.3.17→ "tag v0.3.17 names the version this tree declares (0.3.17)"CI is pending — the push has just happened and nothing here is claimed as green.
tests/test_version_sync.pyis the guard that the declarations agree; it is part of the run above.What a reviewer should check
That the diff is only the version string, in the eight files the script names, and that no file was hand-edited afterwards.