Repository navigation
fix(bundler): only skip v3 reference object slots when dereferencing - #2351
Open
rishabhknowss wants to merge 1 commit into
Open
rishabhknowss wants to merge 1 commit into
rishabhknowss wants to merge 1 commit into
Conversation
The v3 excludedPathMatcher used unanchored patterns, so a schema property named servers, channel or messages kept its external $ref and the bundle was not self-contained. Root extensions with falsy values were dropped. Fixes asyncapi#2347
rishabhknowss
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns,
asyncapi-bot-eve and
princerajpoot20
as code owners
November 17, 2026 06:50
🦋 Changeset detectedLatest commit: c77e58d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



fixes #2347
what
excludedPathMatcherused unanchored patterns like/#\/channels\/.*\/servers/, so any pointer under a channel or operation containing/servers,/channelor/messageswas skipped. a payload property namedserversorserversCount, or an http bindingqueryproperty namedchannel, kept its external$refand the bundle wasn't self-contained.channels.<id>.serversandoperations.<id>[.reply].channel|messages, plus thecomponentsvariants. ref-parser checks every key path before descending, so excluding the slot also skips its items.orderPropsAccToAsyncAPISpeccopied root props only when truthy, droppingx-internal: falseandx-retries: 0. it now checksprop in.testing
tests/v3-schema-propsfrom the issue's repro, plus a localserversref and an operationmessagesref to check the real slots are still left alone.servers/serversCount/channelstill$ref).npx jestinpackages/bundler: 11/11 pass.tsc --noEmitclean.@asyncapi/parserwith no errors (previouslyinvalid-ref).🤖 Generated with Claude Code