Bump the generation when a read promotes an LRUCache entry - #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
LRUPolicy::getmoved the entry to the back of the list without bumping the generation, so a live iterator kept walking the relinked list and the process died. Now a promoting read bumps the generation, and a live iterator raises the same RuntimeError it already raises after an insert. A hit on the most recent entry moves nothing, so it does not bump either: iterating is still safe around it, and the pointless unlink-relink it used to do is gone.PolicyExt::gettakessharednow, the same wayentryalready does; only the LRU policy uses it, the others ignore it.No answers change, eviction order stays exactly the same. A promoting hit pays one atomic increment, 3 ns on my machine; a hit on the most recent entry and misses cost what they cost before.
The test runs the walk in a child process on purpose: without the fix it dies instead of failing.