Repository navigation
Conversation
… that override __init__ or nest records ActiveMQEvent, KafkaEvent, RabbitMQEvent, CodePipelineJobEvent and AWSConfigRuleEvent override __init__ without the json_deserializer parameter DictWrapper accepts, so passing one raised TypeError. RabbitMQEvent, CodePipelineJobEvent, CloudWatchAlarmEvent and ConnectOutboundCampaignsEvent also built nested wrappers without forwarding it, so json_data / decoded_user_parameters / reason_data_decoded / json_customer_data fell back to json.loads.
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8883
Summary
Changes
Five event data classes (
ActiveMQEvent,KafkaEvent,RabbitMQEvent,CodePipelineJobEvent,AWSConfigRuleEvent) now acceptjson_deserializerin__init__and pass it toDictWrapper. Before, passing it raisedTypeError.RabbitMQEvent,CodePipelineJobEvent,CloudWatchAlarmEventandConnectOutboundCampaignsEventnow pass the deserializer on to the nested objects they build.User experience
Before:
KafkaEvent(event, json_deserializer=orjson.loads)raisedTypeError. For the other classes,json_dataand similar properties usedjson.loadswithout notice.After: the custom deserializer is used everywhere. Code that does not pass one behaves as before.
Verification
I added 7 unit tests that use only the public API, one in each of the existing test files. All 7 fail on
develop(4 withTypeError, 3 with wrong output) and pass with this change. Thetests/unit/data_classessuite passes (236 tests). The data_classes, kafka_consumer, batch, parser and event_handler suites also pass (1723 tests).ruff check,ruff format --check,mypyandtyreport no problems. The change adds no new event shapes, so no AWS event was needed.Generated by AI tools, and reviewed and verified by Mohamed Noordeen Alaudeen (@nursnaaz).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.