Repository navigation
Conversation
Contributor
Package TarballHow to installgh release download pr-2746-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.1.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generated Python Strands agents currently discard retrieved records below
0.5, including relevant records returned for a basic recall query in #2706. Set the generated relevance threshold to0.0so retrieval usestop_kwithout default score filtering. This covers the Python Strands, container, A2A, AG-UI, harness-export, and imported Bedrock Agent paths.Use
SEMANTICandEPISODICas the default strategies for memory-enabled runtime templates. Remove preference and summary retrieval from the default Python and TypeScript runtime templates. Harness exports continue to honor the strategies of explicitly configured existing memories and any supplied retrieval thresholds. Managed harness scaffolds keep their original emptymanagedMemoryConfiguration: {}.These defaults apply to newly scaffolded runtime projects. Existing runtime projects can adopt them by updating their memory strategies and generated retrieval configuration.
Related Issue
Closes #2706
Documentation PR
Documentation is included here: the generated runtime template READMEs.
Type of Change
Testing
Full unit suite: 4,705 passed, 6 skipped, 0 failed across 311 files, run in three independent shards.
Regression coverage verifies the provisioned strategies, episodic reflection namespace, matching Python/TypeScript retrieval namespaces, zero default thresholds, imported-agent code, and preservation of explicit
0and0.7export thresholds.Built-CLI smoke tests verify that a managed harness emits
managedMemoryConfiguration: {}and that Python Strands retains semantic/episodic strategies with zero relevance thresholds. The generated runtime templates are also covered by the unit regressions.bun run auditreports a pre-existing moderateminimatchfinding, GHSA-g3hv-75wg-m249, through@aws/agent-inspector. The same finding reproduces with the upstream dependency files. This PR does not changepackage.jsonorbun.lock.Live AWS end-to-end tests were not run: the change concerns scaffolding defaults, which were verified through generated artifacts and the built CLI. No AWS resources were deployed.
I ran
bun testI ran the relevant end-to-end tests with
bun run test:e2e, or explained why they are not applicableI ran
bun run typecheckI ran
bun run lint:checkI ran
bun run format:checkI ran
bun run buildIf I modified
src/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.