Repository navigation
Conversation
16 of 22 tasks
Contributor
|
Thanks for putting this fix together. I tested the original Bun behavior against the repo’s pinned Bun 1.4.0 and confirmed the stdin issue was fixed upstream in oven-sh/bun#33123. I opened #2750 with an alternative approach. It removes the obsolete fd workaround and tests delayed stdin after importing Ink under both Bun and Node. I’m closing this PR in favor of #2750. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Read
process.stdindirectly under Node so secret flags wait for piped input that arrives after the command starts. Retain the fd 0 workaround under Bun, where Ink can drain the process stream before the handler reads it.Adds a Node subprocess regression test that writes to stdin after a delay and checks the resolved value.
Related Issue
Closes #2747
Documentation PR
Not applicable; command syntax and documented behavior are unchanged.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themThe
src/io/source.test.tssuite passed (15 tests). TypeScript checking passed withtsc --noEmit. AWS end-to-end tests are not applicable because this changes local stdin handling only.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.