Repository navigation
docs(python-uv): consolidate DESIGN.md after the uv fixes - #971
Merged
bnusunny merged 4 commits intoNov 18, 2026
Merged
Conversation
UvConfig accepts compile_bytecode but never passes it to uv, so the example implied a setting the build does not apply.
…esign-consolidation # Conflicts: # aws_lambda_builders/workflows/python_uv/DESIGN.md
1 task done
vicheey
approved these changes
Nov 18, 2026
vicheey
left a comment
Contributor
There was a problem hiding this comment.
Thanks for pulling this together, it reads much closer to the code now.
- Lines 148-149:
-e ../sharedresolves from the manifest directory, but an editable requirement installs only a.pthpointing at the build machine's path, so the package isn't in the artifact. Could the example use a non-editable path like../sharedinstead? That also keeps it consistent with "nothing is installed editable" further down. - Line 110: the workflow also auto-detects when the given manifest path doesn't exist (
workflow.py), so maybe "Without one, or when the given path doesn't exist, ...". - Nit (optional): the new "Stale locks" paragraph and the "uv warnings" section repeat lines 122-124 and 260-262. While you're in the file, the docstring's "when present in the same directory" (62-63) and "Minimum UV version: 0.1.0" (367) are also stale.
licjun
approved these changes
Nov 18, 2026
bnusunny
enabled auto-merge (squash)
November 18, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #839
Description of changes
Docs only. Brings
aws_lambda_builders/workflows/python_uv/DESIGN.mdin line with the merged python_uv fixes:uv lockwritesuv.lockin the project directory, or at the workspace root for a workspace member (fix(python-uv): properly support the workspace (in particular, to prevent crashes when other members' editable installations are included in dependencies) #887).uv export --lockedfails the build on a stale lock, and that a project withoutrequires-pythonlocked on one Python version can be stale on another runtime (fix: validate uv exports without dropping lock options #954).require-hashesprojects build (fix(python-uv): keep lock hashes so require-hashes projects build #959).[tool.uv]key matters (feat(python-uv): add build options (groups, extras, prune) and show uv warnings #966).Description of how you validated changes
Checked the text against
aws_lambda_builders/workflows/python_uv/*.pyon develop.make lintandmake black-checkpass.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.