Repository navigation
fix(python-uv): reject pruning the project itself; test uv_all_extras - #972
Merged
Merged
Conversation
🧪 Hands-on test: No problems observed in 6 scenariosCommit Scenarios
Runner's notes in full
🤖 Automated hands-on test — not a review approval · model claude-opus-5.5 · Kiro kiro-cli 2.33.1 · build History (3)
|
bnusunny
force-pushed
the
fix/python-uv-966-followups
branch
from
November 18, 2026 19:13
838d746 to
52d0524
Compare
1 task done
vicheey
approved these changes
Nov 18, 2026
vicheey
left a comment
Contributor
There was a problem hiding this comment.
Thanks! A couple of small things:
- DESIGN.md lists the cases where the build fails instead of ignoring an option (under "Build options"). Could you add this one there?
- Optional:
test_prune_without_a_project_name_is_left_to_uvdoesn't have a case for a non-string name (name = 1) or a non-tableproject(project = "x"), so the twoisinstancechecks in_project_namearen't covered.
licjun
approved these changes
Nov 18, 2026
bnusunny
enabled auto-merge (squash)
November 19, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Follow-up to #966
Description of changes
Follow-ups from the review of #966.
uv_prunenow fails validation when it names the project being built. Before,uv export --prune <project>exported nothing, and the build passed with no dependencies.[project].namein the function's pyproject.toml. Names are compared after PEP 503 normalization, soMy_Appmatchesmy-app.test_options_are_passed_to_the_build_actionnow also coversuv_all_extras: True, as its own case because it cannot be combined withuv_extras.Description of how you validated changes
make lintandmake black-checkpass.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.