Repository navigation
feat(python-uv): add uv_compile_bytecode build option #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bnusunny
merged 2 commits into
aws:develop
from
bnusunny:feat/python-uv-compile-bytecode-option
Nov 19, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BUG] Bytecode enabled with no manifest crashes the build with a TypeError
Before this change, any truthy
uv_*option on a build with no manifest stopped atself._fail(...). Now that check runs only whenexport_optionsis non-empty. Ifuv_compile_bytecodeis the only truthy value, the code goes on to the unchangedproject_name = self._project_name(manifest_path).That value can also come from a truthy
UV_COMPILE_BYTECODEin the environment. Whendetect_uv_manifestfinds nothing,__init__setsmanifest_path = None._project_name(None)then callsopen(None, "rb"), which raisesTypeError._project_nameonly catchesOSErrorandValueError, so the error is not handled.The result: a user with
UV_COMPILE_BYTECODE=1set globally who builds a function with nopyproject.tomlorrequirements.txtgets an unhandled exception while the workflow is being built. Before this change, the build continued without dependencies. No build action uses the config when there is no manifest.Fix: only call
_project_namewhen it's needed (if values.get("uv_prune")). Alternatively, returnUvConfig(compile_bytecode=...)before the project-name check whenmanifest_pathisNoneandexport_optionsis empty.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced by a hands-on run 🧪
Commit
02ea32f· buildLambdaToolingHandsOn-NoDocker:ed9079ab-7324-4df2-8610-14f93149e8d1· scenario S4 · reproduced 2 times · exit codes 2, 2, 0Commands:
Evidence:
🤖 Automated hands-on test — not a review approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and reproduced on develop: with no manifest,
_project_name(None)raisedTypeError. Fixed in #976, which reads the project name only whenuv_pruneis set. With no manifest the build continues without dependencies, as before this PR.