Repository navigation
chore: extract tar files with the PEP 706 data filter - #975
Merged
Merged
Conversation
Pass filter="data" to tar.extractall() when tarfile.data_filter is available (Python 3.10.12+, 3.11.4+, 3.12+). This matches the default Python uses from 3.14. Older patch releases keep the current call.
bnusunny
force-pushed
the
fix/tar-data-filter
branch
from
November 18, 2026 21:56
b44e264 to
730ea57
Compare
vicheey
approved these changes
Nov 18, 2026
licjun
approved these changes
Nov 18, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes
extract_tarfilenow passesfilter="data"(PEP 706) totar.extractall()whentarfile.data_filteris available (Python 3.10.12+, 3.11.4+, 3.12+). This matches the default Python uses from 3.14, so tarballs extract the same way on every supported Python. Older patch releases withoutdata_filterkeep the current call.Description of how you validated changes
tests/functional/test_utils.pyfor the filter's behaviour (links outside the unpack directory are rejected, the executable bit is kept). Passing on Python 3.10 to 3.14.tests/unitand related functional tests pass.tests/integration/workflows/nodejs_npm(realnpm pack) passes.black --check,ruff checkandmypyare clean.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.