Repository navigation
fix(python-uv): don't crash when bytecode is on and there is no manifest - #976
Merged
bnusunny merged 1 commit intoNov 19, 2026
Merged
Conversation
With uv_compile_bytecode (or a truthy UV_COMPILE_BYTECODE) and no pyproject.toml or requirements.txt, _uv_config_from_options called _project_name(None) and raised TypeError. Only uv_prune needs the project name, so read it only then. The build now continues without dependencies, as before aws#973.
🧪 Hands-on test: No problems observed in 7 scenariosCommit Scenarios
Runner's notes in full
🤖 Automated hands-on test — not a review approval · model claude-opus-5.5 · Kiro kiro-cli 2.33.1 · build History (1)
|
1 task done
vicheey
approved these changes
Nov 19, 2026
licjun
approved these changes
Nov 19, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Follow-up to #973 (bot finding)
Description of changes
With
uv_compile_bytecode: true, or a truthyUV_COMPILE_BYTECODE, and nopyproject.tomlorrequirements.txt, the python_uv workflow raisedTypeError: expected str, bytes or os.PathLike object, not NoneTypewhile it was being set up._uv_config_from_optionscalled_project_name(None), andopen(None)isn't anOSError.Only
uv_pruneneeds the project name, and it can only get that far with apyproject.tomlmanifest. So the name is now read only whenuv_pruneis set. With no manifest the build continues without dependencies, as before #973.Description of how you validated changes
uv_compile_bytecode: True, and no manifest withUV_COMPILE_BYTECODE=1. Both fail without the fix.requirements.txt-less function built withUV_COMPILE_BYTECODE=1) now builds and outputsapp.py.make lintandmake black-checkpass.pytest tests/unitpasses (1077), andtests/integration/workflows/python_uvpasses with real uv 0.13.9 (72).Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.