Skip to content

fix(examples): make validate pass on cfn-lint 1.58 (LMI GetAtt, dotnet8 EOL) - #917

Merged
bnusunny merged 1 commit into
mainfrom
fix/examples-validate
Nov 13, 2026
Merged

bnusunny merged 1 commit into
mainfrom
fix/examples-validate

Conversation

@bnusunny

Copy link
Copy Markdown
Contributor

validate has been red on main since 2026-10-23, and every PR that touches examples/ inherits the failure.

  • fastapi-response-streaming-lmi: cfn-lint now validates SAM resources against its bundled SAM schemas instead of transforming them. The bundled schema for AWS::Serverless::CapacityProvider declares no attributes, so !GetAtt LMICapacityProvider.Arn fails E1010 (function) and E6101 (output), even though SAM supports it. This PR ignores E1010 on FastAPIFunction and E6101 at template level (Outputs can't carry Metadata). Each ignore has a comment saying when to remove it.
  • aspnet-mvc-zip, aspnet-webapi-zip: dotnet8 was deprecated on 2026-11-10 (W2531), and sam validate --lint fails on warnings. This PR moves both to dotnet10 / net10.0.

Testing

With SAM CLI 1.172.1 and cfn-lint 1.58.0 (the versions setup-sam installs today):

  • On main, the validate loop reproduces all three failures.
  • On this branch, all 45 example templates pass sam validate --lint, and .github/scripts/check-example-config.sh passes.
  • Both ASP.NET projects dotnet publish -c Release on the .NET 10 SDK (mcr.microsoft.com/dotnet/sdk:10.0).

Unblocks

These grouped Dependabot security PRs fail only on main's validate. After this merges, comment @dependabot rebase on each so its checks re-run on the fixed main:
#900, #901, #903, #904, #905, #906, #907, #911, #912, #915

…t8 EOL)

- fastapi-response-streaming-lmi: cfn-lint's bundled SAM schema for
  AWS::Serverless::CapacityProvider declares no attributes, so
  !GetAtt LMICapacityProvider.Arn fails E1010 (function) and E6101
  (output). Ignore E1010 on FastAPIFunction and E6101 at template level
  (Outputs cannot carry Metadata) until cfn-lint ships the attribute.
- aspnet-mvc-zip, aspnet-webapi-zip: dotnet8 was deprecated on
  2026-11-10 (W2531). Move to dotnet10 and net10.0.
@bnusunny
bnusunny requested a review from a team as a code owner November 13, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants