Repository navigation
fix(examples): make validate pass on cfn-lint 1.58 (LMI GetAtt, dotnet8 EOL) - #917
Merged
Merged
Conversation
…t8 EOL) - fastapi-response-streaming-lmi: cfn-lint's bundled SAM schema for AWS::Serverless::CapacityProvider declares no attributes, so !GetAtt LMICapacityProvider.Arn fails E1010 (function) and E6101 (output). Ignore E1010 on FastAPIFunction and E6101 at template level (Outputs cannot carry Metadata) until cfn-lint ships the attribute. - aspnet-mvc-zip, aspnet-webapi-zip: dotnet8 was deprecated on 2026-11-10 (W2531). Move to dotnet10 and net10.0.
vicheey
approved these changes
Nov 13, 2026
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validatehas been red on main since 2026-10-23, and every PR that touchesexamples/inherits the failure.AWS::Serverless::CapacityProviderdeclares no attributes, so!GetAtt LMICapacityProvider.Arnfails E1010 (function) and E6101 (output), even though SAM supports it. This PR ignores E1010 onFastAPIFunctionand E6101 at template level (Outputs can't carryMetadata). Each ignore has a comment saying when to remove it.dotnet8was deprecated on 2026-11-10 (W2531), andsam validate --lintfails on warnings. This PR moves both todotnet10/net10.0.Testing
With SAM CLI 1.172.1 and cfn-lint 1.58.0 (the versions
setup-saminstalls today):validateloop reproduces all three failures.sam validate --lint, and.github/scripts/check-example-config.shpasses.dotnet publish -c Releaseon the .NET 10 SDK (mcr.microsoft.com/dotnet/sdk:10.0).Unblocks
These grouped Dependabot security PRs fail only on main's
validate. After this merges, comment@dependabot rebaseon each so its checks re-run on the fixed main:#900, #901, #903, #904, #905, #906, #907, #911, #912, #915