Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
None filed. Found by code review.
Why is this change necessary?
parse_s3_urlraisesIndexErrorfor a path-style S3 URL that has no object key, such ashttps://s3.us-east-1.amazonaws.com/bucketorhttps://s3.us-east-1.amazonaws.com/. Callers such asis_s3_protocol_urlonly catchValueError, so aCodeUriorTemplateURLlike that endssam packageorsam deletewith a traceback.s3://fooandhttps://s3.us-east-1.amazonaws.comalready raiseValueError.How does it address the issue?
_parse_path_style_s3_urlonly fills in the bucket and key when both are present, so these URLs raise the sameValueErroras the other invalid forms. Two URLs were added to the existing invalid-URL unit test.What side effects does this change have?
None for valid URLs. Invalid path-style URLs now raise
ValueErrorinstead ofIndexError.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpasses (I ran the related unit tests, 338 passed, plus ruff, black and mypy on the changed files; CI will run the full target)make update-reproducible-reqsif dependencies were changed (no dependency change)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.