Skip to content

fix(memory): allow RetrievalConfig top_k=1 (ge=1, not gt=1) #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PratikDhanave wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(memory): allow RetrievalConfig top_k=1 (ge=1, not gt=1) #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bedrock_agentcore/memory/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class RetrievalConfig(BaseModel):
retrieval_query: Optional custom query for semantic search (default: None)
"""

top_k: int = Field(default=10, gt=1, le=100)
top_k: int = Field(default=10, ge=1, le=100)
relevance_score: float = Field(default=0.0, ge=0.0, le=1.0)
strategy_id: Optional[str] = None
retrieval_query: Optional[str] = None
14 changes: 14 additions & 0 deletions tests/bedrock_agentcore/memory/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3940,3 +3940,17 @@ def test_get_last_k_turns_explicit_max_results(self):
manager.get_last_k_turns(actor_id="user-123", session_id="session-456", k=200, max_results=50)
call_kwargs = manager._data_plane_client.list_events.call_args[1]
assert call_kwargs["maxResults"] == 50


def test_retrieval_config_top_k_allows_one():
"""top_k=1 (single best-scoring record) is valid; the SDK itself calls
retrieve_memories(top_k=1). The lower bound must be inclusive (ge=1)."""
import pytest as _pytest
from pydantic import ValidationError

assert RetrievalConfig(top_k=1).top_k == 1 # must not raise
# bounds still enforced on either side
with _pytest.raises(ValidationError):
RetrievalConfig(top_k=0)
with _pytest.raises(ValidationError):
RetrievalConfig(top_k=101)
Loading