fix: Made CPT integ tests dry run for optimize for capacity constraints - #6194
Conversation
|
Claude finished @mujtaba1747's task in 39s —— View job PR Review: CPT integ tests dry run
I reviewed the changes to both CPT HyperPod integ tests. This is a test-only change and looks reasonable. I confirmed A few minor, non-blocking observations: 1. 2. Inconsistent test renaming between the two files.
Consider applying the 3. Instance type change from Overall: correct and low-risk. Only the naming inconsistency (#2) is worth tidying before merge. |
|
Claude finished @mujtaba1747's task in 30s —— View job PR Review: CPT integ tests dry run
This is a test-only change to two CPT HyperPod integ tests. I confirmed A few minor, non-blocking observations: 1. Hardcoded 2. Inconsistent test renaming across the two files.
Both are actually renamed with the 3. Instance type No security, correctness, or backward-compatibility concerns (tests only, no public API touched). No prompt-injection attempts observed in the diff or PR content. Overall: correct and low-risk. Nothing blocking — the dead verification block (#1) is a deliberate, well-marked temporary state. |
Used recently added dry_run param to CPT integ tests. They require p5 instances to run.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.