Repository navigation
Add requalify_ticket and guard the requalified envelope (0.6.0, breaking) - #12
Merged
Merged
Conversation
…flow envelope (0.6.0), refusing a raw send of it unless allowed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…odies, in the async source and its generated sync twin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 98.96% 98.97%
=======================================
Files 40 40
Lines 2715 2728 +13
=======================================
+ Hits 2687 2700 +13
Misses 28 28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
requalify_ticketand names therequalifiedbody as a workflow envelope. Release 0.6.0, which contains a breaking change.requalify_ticket(rfc_number, *, allow_workflow_effect, catalog_id=None, catalog_code=None, catalog_guid=None). It sendsPUT requests/{rfc}with arequalifiedbody holding exactly one catalog key. Passing no key or several raisesValueErrorbefore any request is made. The vendor documents a requalification as starting a new workflow (action.md). The method never re-reads the ticket: the caller confirms the change landed withget_ticket. One instance was measured answering HTTP 590 to an incident requalification that had in fact landed; that may not hold elsewhere.requalifiedis now anUNKNOWNworkflow envelope. It matches a top-level body key in any casing on any path. A rawsendof arequalifiedbody is refused unless the call allowsWorkflowEffect.UNKNOWN. Before this change, the nested catalog key passed the guard unseen.senddocstring andvendor-api-reference.mdlistrequalifiedwith the other guarded envelopes.docs/user_guide.rstthat said suspend and reopen were "not wrapped here". They are wrapped since 0.5.0.Tests
unasync --check,lint_hand_written_sync, mypy, sphinx-W.Note:
ruff format --check .already fails onmainin files this branch does not touch. Those files are left as they are.🤖 Generated with Claude Code