Repository navigation
install.sh: installs superfluid, the server basert serve runs, beside basert - #69
Open
IsuraManchanayake wants to merge 1 commit into
Open
IsuraManchanayake wants to merge 1 commit into
IsuraManchanayake wants to merge 1 commit into
Conversation
… basert basert 0.4.0 does not bundle superfluid: after unpacking, the script runs the installed basert's own installer, which downloads the release that basert was tested with, checks its SHA-256 against the published one and puts it beside basert. The step is skipped for a release without the command and is not fatal: basert serve installs superfluid at its first start, and basert superfluid install does it by hand.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
After unpacking the bundle, the installer runs
basert superfluid install, the installed basert's own installer for superfluid, the serverbasert serveruns from 0.4.0 on: it downloads the superfluid release that basert was tested with, checks its SHA-256 against the one the release publishes, and puts it beside basert, wherebasert servelooks first. The step is skipped for a release whose basert has no such command (0.3.x and earlier) and is not fatal when the download fails:basert serveinstalls superfluid at its first start, and the command to run by hand is printed. The "Try it" lines gainbasert serve.Why
baseRT 0.4.0 ships no server of its own:
basert serveruns superfluid (https://github.com/basecompute/superfluid), which is not bundled with basert. The script is where most users get basert, so it is where superfluid should arrive too, without a second implementation of the download: the pin, the platform and the checksum live in basert.How it was tested
sh -n install.sh.basert superfluid install, is exercised in baseRT-internal's launcher PR (basecompute/baseRT-internal#722): against a fake release in the tests, and against a real superfluid build laid out as a release.