Skip to content

Align BccReact with the design - #431

Merged
covaci-edvin merged 3 commits into
mainfrom
fix/react-design
Oct 21, 2026
Merged

covaci-edvin merged 3 commits into
mainfrom
fix/react-design

Conversation

@covaci-edvin

@covaci-edvin covaci-edvin commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Change summary

Aligns BccReact with the React component in BCC Prime Components 2.0, for both the empty and the populated state.

  • Add-reaction icon: 20px → 24px
  • Row height: 32px in both states (was 40px populated, 24px empty)
  • Placeholder text ("Be the first to react"): heading-xs (12px) → heading-sm (14px / 16px)
  • Reaction pills: removed the extra vertical margin, so they sit centered in the 32px row
  • Pill shadow: drop-shadow → shadow-raised (the shadow/raised effect from Figma)
  • Pills get a thin border (border-default) in dark mode, where the shadow is hard to see
  • Count line-height: 14px → 16px
  • The reaction selector popup keeps its 4px gap below the shorter row

Unchanged: emoji size (already 20px), gaps (6px empty, 8px icon → pills, 6px between pills) and the selector popup and dropdown.

Screenshots

Before
image

After
image

Change type

  • No review
  • Small PR
  • Big PR
  • Refactor

🤖 Generated with Claude Code

@u12206050 u12206050 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On dark mode could we have a subtle border on the buttons since the shadow isn't visible and from your screenshot the buttons merge in with the background.

@covaci-edvin

Copy link
Copy Markdown
Contributor Author

On dark mode could we have a subtle border on the buttons since the shadow isn't visible and from your screenshot the buttons merge in with the background.

@u12206050 added and updated screenshot

Comment thread component-library/src/components/custom/BccReact/BccReact.css Outdated

@u12206050 u12206050 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@covaci-edvin
covaci-edvin merged commit fe3ea86 into main Oct 21, 2026
6 checks passed
@covaci-edvin
covaci-edvin deleted the fix/react-design branch October 21, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants