Repository navigation
Align BccReact with the design - #431
Merged
Merged
Conversation
covaci-edvin
requested review from
bogdaniculae,
jasverix and
u12206050
as code owners
October 19, 2026 08:44
covaci-edvin
requested review from
bogdaniculae
and removed request for
bogdaniculae
October 19, 2026 08:57
u12206050
reviewed
Oct 19, 2026
u12206050
left a comment
Member
There was a problem hiding this comment.
On dark mode could we have a subtle border on the buttons since the shadow isn't visible and from your screenshot the buttons merge in with the background.
Contributor
Author
@u12206050 added and updated screenshot |
u12206050
reviewed
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Aligns
BccReactwith the React component in BCC Prime Components 2.0, for both the empty and the populated state.heading-xs(12px) →heading-sm(14px / 16px)drop-shadow→shadow-raised(theshadow/raisedeffect from Figma)border-default) in dark mode, where the shadow is hard to seeUnchanged: emoji size (already 20px), gaps (6px empty, 8px icon → pills, 6px between pills) and the selector popup and dropdown.
Screenshots
Before

After

Change type
🤖 Generated with Claude Code