Repository navigation
Conversation
package.json said WordPress 3.0 and PHP 5.3, so the updater offered new versions to sites they break. The plugin's scripts need WordPress 6.6 (react-jsx-runtime) and its PHP needs 7.4 (typed properties). The updater now also accepts a site that runs exactly the required version. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Compatibility metadata remains contradictory, and prerequisite PR #228 has not yet been released.
2 open findings
What changed in this PR
Declares BCC Login’s runtime requirements and aligns update eligibility checks.
Changes:
- Requires WordPress 6.6 and PHP 7.4.
- Allows updates when versions exactly meet minimums.
- Adds matching WordPress plugin headers.
| File | Description |
|---|---|
plugins/bcc-login/package.json |
Updates minimum versions. |
plugins/bcc-login/includes/class-bcc-login-updater.php |
Makes minimum comparisons inclusive. |
plugins/bcc-login/bcc-login.php |
Adds activation requirement headers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
"tested" was still 5.8, below the new minimum of 6.6, so WordPress would call the plugin untested on every version it supports. It ran on WordPress 7.0.2 in the tests of these changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
bcc-login's
package.jsonsays it needs WordPress 3.0 and PHP 5.3. The plugin's updater reads these values frommasterand offers new versions to every site above them, including sites the new versions break:react-jsx-runtime, which WordPress added in 6.6. On older versions WordPress doesn't load them.is_favicon(), which runs on every front-end request).The updater also compared with
<, so a site running exactly the required WordPress version (WordPress reports 6.6.0 as6.6) never got updates.Changes
package.json:requires6.6,requires_php7.4, andtested7.0 (it said 5.8, below the new minimum).<=).bcc-login.php:Requires at least: 6.6andRequires PHP: 7.4headers, so WordPress itself won't activate the plugin on older versions.The updater reads
package.jsonfrommaster, so once this is merged, sites below WordPress 6.6 or PHP 7.4 stop being offered updates. They keep the version they have.Merging
master, sites below WordPress 6.6 or PHP 7.4 stop getting updates, including the release that makes them report. With a day in between, they still pick up the report first, so the inventory shows exactly those sites.last_updated, the line afterrequires_php, on every release. After another bcc-login release this branch needs a rebase: keep both changes inpackage.json.<check until they update. So a site on exactly WordPress 6.6.0 gets this release only once it's on 6.6.1 or later. The<=change helps from the next release on.Testing
php -lon PHP 7.4. The only PHP 8 function in use,str_contains, is provided by WordPress 5.9+.settings.asset.phpandvisibility.asset.phplistreact-jsx-runtimeas a dependency.🤖 Generated with Claude Code