FEAT: Improve interactions of user pools - #1009
Open
ColmTalbot wants to merge 21 commits into
Open
Conversation
ColmTalbot
marked this pull request as draft
October 30, 2025 14:22
ColmTalbot
marked this pull request as ready for review
November 3, 2025 16:03
ColmTalbot
added
>100 lines
refactoring
sampling
mj-will
reviewed
Dec 11, 2025
mj-will
left a comment
mj-will
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, I look forward to trying it! I've added some initial comments but might need to have a second look.
ColmTalbot
commented
Jan 23, 2026
ColmTalbot
left a comment
ColmTalbot
left a comment
Collaborator
Author
There was a problem hiding this comment.
I don't remember exactly what the behaviour for some of these questions is, so I'll go back and check, and ideally write docstrings about them.
mj-will
requested changes
Apr 30, 2026
mj-will
left a comment
mj-will
left a comment
Collaborator
There was a problem hiding this comment.
Forgot to submit my comments as a review, but see them above.
mj-will
reviewed
Apr 30, 2026
adivijaykumar
left a comment
adivijaykumar
left a comment
Collaborator
There was a problem hiding this comment.
Can we add a test for schwimmbad/MPI support?
Collaborator
|
We should documentation for user pools and note that the pool will only work correctly in the initializer has been called. |
ColmTalbot
commented
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that it was difficult to pass a user-specified pool through run_sampler, and it isn't used at all in the post processing. This PR:
with multiprocessing.pool()...)Sampler._setup_poolandSampler._close_poolparallel_bilbymoot.